bito-code-review[bot] commented on code in PR #43472:
URL: https://github.com/apache/superset/pull/43472#discussion_r3851060897
##########
superset-frontend/packages/superset-ui-core/src/components/Table/VirtualTable.tsx:
##########
@@ -147,6 +149,28 @@ const VirtualTable = <RecordType extends object>(
const { ref } = useResizeDetector({ onResize });
const theme = useTheme();
+ const cellSize = size === TableSize.Middle ? MIDDLE : SMALL;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete size enum mapping</b></div>
<div id="fix">
`size === TableSize.Middle ? MIDDLE : SMALL` silently maps both
`TableSize.Small` and `TableSize.Large` to 39px, but `TableSize.Large` is a
distinct, user-visible size that should render a taller row. If Large is
intentionally collapsed into Small's height, document it; otherwise branch on
`TableSize.Large` or adjust the default accordingly. Also note `dataSource` is
already extracted at line 142, so moving `cellSize` to after the destructuring
block is safe.
</div>
</div>
<small><i>Code Review Run #5493ea</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
