EnxDev commented on code in PR #43339:
URL: https://github.com/apache/superset/pull/43339#discussion_r3851757037
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1243,6 +1244,23 @@ export default function transformProps(
})()
: xAxisFormatter;
+ // Weekly grains: pin the ticks to the buckets ECharts would otherwise miss.
+ // A timeseries annotation contributes its own timestamps and widens the axis
+ // past the buckets, and ECharts clips pinned ticks to the extent, so that
+ // span would render bare — leave those charts on ECharts' own ticks.
+ const hasTimeseriesAnnotation = annotationLayers.some(
Review Comment:
reasonable idea but nontrivial scope; current behavior is safely conservative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
