villebro commented on code in PR #43516:
URL: https://github.com/apache/superset/pull/43516#discussion_r3855701861
##########
superset/websocket/channel.py:
##########
@@ -118,12 +119,13 @@ def register_ws_channel_cookie(app: Flask) -> None:
@app.after_request
def set_ws_channel_cookie(response: Response) -> Response:
- channel_id = get_channel_id()
+ channel_id = get_channel_id() if can_access_realtime_notifications()
else None
Review Comment:
Addressed as a bounded-revocation tradeoff rather than adding an immediate
revocation channel in this focused PR. The websocket server already terminates
sockets after JWT exp; commit 5c5b4c9e65 lowers the default
WEBSOCKET_JWT_EXPIRATION_SECONDS to 15 minutes and documents that post-mint
permission revocation is bounded by token expiry plus the websocket
socket-check interval. A dedicated revocation stream or introspection path can
be added if we need immediate disconnect semantics.
##########
superset/tasks/async_queries.py:
##########
@@ -164,7 +164,9 @@ def submit_chart_data_query_tasks(
the websocket transport subscribes to GTF, not to any GAQ-specific stream.
Returns the HTTP 202 body ``{"task_ids": [...]}`` — the query tasks'
UUIDs, in
- query order, for the client to poll and cancel via the GTF task API.
+ query order, for the client to poll through the GTF task API. Client
aborts may
+ unsubscribe from shared work or abort pending work; engine-level query
+ cancellation is outside this chart async path.
Review Comment:
Resolved on current head: the docstring now documents the HTTP 202 body as
{"task_ids": [...], "cursor": "..."} and explains that the client uses the
server-issued polling cursor with the GTF task API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
