sadpandajoe commented on code in PR #43501:
URL: https://github.com/apache/superset/pull/43501#discussion_r3857346252
##########
superset/db_engine_specs/cockroachdb.py:
##########
@@ -44,7 +44,7 @@ class CockroachDbEngineSpec(PostgresEngineSpec):
DatabaseCategory.TRADITIONAL_RDBMS,
DatabaseCategory.OPEN_SOURCE,
],
- "pypi_packages": ["cockroachdb"],
+ "pypi_packages": ["sqlalchemy-cockroachdb"],
Review Comment:
The generated database documentation still advertises `cockroachdb` as the
required package, so operators following that page will install the
SQLAlchemy-2.0-incompatible dependency this change replaces. Could the database
docs artifact be regenerated to publish `sqlalchemy-cockroachdb` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
