aminghadersohi commented on PR #43479: URL: https://github.com/apache/superset/pull/43479#issuecomment-5417098916
Requested review from @eschutho — she owns the recent history on \`superset/views/error_handling.py\` (including #43xxx-era work mapping exception status/log-levels and the SSH-tunnel logging downgrade), which is exactly the second half of this diff. cc @mikebridge — you own the recent \`superset/daos/base.py\` changes (SoftDeleteMixin, LIKE-operator semantics); you are not an ASF collaborator so GitHub will not let me formally request you, but your eyes on the three DAO guards would be valuable. Two things worth a reviewer's attention, both flagged by the author in the PR body: 1. The analytic-database routes under \`handle_api_exception\` (\`DatabaseRestApi.tables\`, \`Api.query\`, \`Datasource\` views) now return 500 instead of 422 when a user-configured warehouse is unreachable — a wider behavior change than the DAO fix. 2. The new 500 path returns \`utils.error_msg_from_exception(ex)\`, i.e. the raw driver message. Given #43xxx (\`fix(embedded): redact database errors in API responses to guest users\`), it is worth confirming connection strings/hostnames in an \`OperationalError\` cannot leak through this new clause on guest-token routes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
