sadpandajoe commented on code in PR #43413: URL: https://github.com/apache/superset/pull/43413#discussion_r3857669996
########## requirements/base.in: ########## @@ -52,11 +52,11 @@ marshmallow-sqlalchemy>=1.5.0 # needed for python 3.12 support openapi-schema-validator>=0.6.3 -# Pin setuptools <81 until all dependencies migrate from pkg_resources to importlib.metadata +# Pin setuptools <85 until all dependencies migrate from pkg_resources to importlib.metadata # pkg_resources is deprecated and will be removed in setuptools 81+ (around 2025-11-30) # Known affected packages: Preset's 'clients' package # See docs/docs/contributing/pkg-resources-migration.md for details -setuptools<81 +setuptools<85 Review Comment: `setuptools<85` now permits releases where `pkg_resources` is absent, even though this constraint identifies `clients` as still importing it. A fresh resolution will select 84.0.0 and break those installs; should this stay below the removal version until that migration lands? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
