villebro commented on PR #42429: URL: https://github.com/apache/superset/pull/42429#issuecomment-5418269061
> @villebro iso.org's right that IR-30 is the current code, ISO renumbered Alborz there in the Nov 2020 amendment. This file's still on the pre-2020 scheme everywhere else though (North Khorasan's IR-31 here vs today's IR-28, Qazvin's IR-28 vs today's IR-26), so IR-32 keeps it consistent with the rest of the file rather than matching iso.org today. aminghadersohi has the full history above if you want more detail. Got it, thanks for the context. I wish they didn't do these type of changes for _existing_ entities. Dimension immutability (only incremental ids, not repurposing/changing old ones) really should be a hard requirement on the ISO spec.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
