sadpandajoe opened a new pull request, #43531: URL: https://github.com/apache/superset/pull/43531
## Summary The navbar's "+" (new), theme switcher, and Settings dropdown carets render noticeably larger than in previous releases. ## Root cause `c11be72ead` (#36010) changed the caret icon prop from `Icons.CaretDownOutlined` to `Icons.DownOutlined` in `RightMenu.tsx` (+ and Settings dropdowns) and `useThemeMenuItems.tsx` (theme switcher). `DownOutlined` renders visibly larger than `CaretDownOutlined` at the same `iconSize="xs"`, causing the regression. This is unrelated to the antd v5→v6 upgrade (#41636), which was the original suspicion. ## Fix Revert the three caret icons back to `Icons.CaretDownOutlined`, matching the still-correct `LanguagePicker` caret and restoring pre-regression sizing. ## Testing - `RightMenu.test.tsx` and `useThemeMenuItems.test.tsx`: 34/34 passing - `oxlint` on touched files: clean ## Before / After Before: carets render large/bold next to +, theme switcher, and Settings. After: carets match the small size used elsewhere in the navbar (e.g. the language picker). Screenshots to follow in a PR update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
