bito-code-review[bot] commented on PR #43527:
URL: https://github.com/apache/superset/pull/43527#issuecomment-5419427497

   <!-- Bito Reply -->
   The PR already includes the necessary logic to handle the `ARROW` format in 
the chart-data response path. Specifically, 
`superset/common/query_context_processor.py` has been updated to include a 
check for `ChartDataResultFormat.ARROW` in the `get_data` method, which then 
calls the newly added `_to_arrow_ipc` static method to serialize the dataframe 
into an Arrow IPC stream. This implementation allows the `/api/v1/chart/data` 
endpoint to return Arrow-formatted data directly.
   
   **superset/common/query_context_processor.py**
   ```
   def get_data(
           self, df: pd.DataFrame, coltypes: list[GenericDataType]
       ) -> str | bytes | list[dict[str, Any]]:
           if self._query_context.result_format == ChartDataResultFormat.ARROW:
               return self._to_arrow_ipc(df)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to