no-hup opened a new pull request, #43546:
URL: https://github.com/apache/superset/pull/43546

   ### SUMMARY
   The development setup guide tells contributors to install Node.js 22 (LTS) 
and npm 10, and to run `nvm install --lts`. The frontend's `package.json` 
engines field requires `node ^24.16.0` / `npm ^11.13.0`, and 
`superset-frontend/.nvmrc` pins `v24.16.0`, so following the guide as written 
fails the engines check on install. This updates the stated versions to Node 24 
/ npm 11, points at `.nvmrc` for the exact version, and switches the snippet to 
bare `nvm install` / `nvm use` so nvm picks up the `.nvmrc` pin instead of 
whatever LTS happens to be.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (docs only)
   
   ### TESTING INSTRUCTIONS
   Compare the guide against `superset-frontend/package.json` (`engines`) and 
`superset-frontend/.nvmrc`. From `superset-frontend/`, `nvm install && nvm use` 
now lands on the pinned v24.16.0.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to