sadpandajoe commented on code in PR #42484:
URL: https://github.com/apache/superset/pull/42484#discussion_r3868072124
##########
superset/reports/api.py:
##########
@@ -717,7 +717,7 @@ def slack_channels(self, **kwargs: Any) -> Response:
channels = channels[start : start + page_size]
return self.response(200, count=count, result=channels)
except SupersetException as ex:
- logger.error("Error fetching slack channels %s", str(ex))
+ logger.warning("Error fetching slack channels %s", str(ex))
Review Comment:
This now logs every `SupersetException` as a warning, including
`SlackChannelListingError` for rate limits and transport failures. Those paths
are intentionally classified as transient 500-level outages in
`get_channels_with_search()`, so this endpoint will no longer emit an
error-level signal when Slack is unavailable. Could this keep `ERROR` for the
transient listing exception and reserve `WARNING` for the client/auth case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
