rusackas commented on PR #41434: URL: https://github.com/apache/superset/pull/41434#issuecomment-5434857974
Codeant's thread on the offsetWidth check is still open, and it looks right to me. The description says the test checks for overflow but the assertion doesn't. Worth adding before this merges, but otherwise looking good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
