rusackas commented on PR #43180: URL: https://github.com/apache/superset/pull/43180#issuecomment-5435007568
Nice diagnosis, and the new tests do cover #36406 cleanly. Wanted to flag the side effect: this makes label-to-color assignment effectively unique across the whole dashboard while the palette lasts, not just per-chart anymore. The `LabelsColorMapSingleton.test.ts` change shows it, `c` now gets `blue` instead of duplicating `a`'s `yellow`, even though those are unrelated labels in different slices. That's a behavior change for every dashboard on the shared color map, not just the two-charts-sharing-a-label case from the issue. @bikash-barnwal is that the intended fix, or should reservation be scoped so charts with disjoint label sets keep their own independent palettes like before? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
