bito-code-review[bot] commented on code in PR #38695:
URL: https://github.com/apache/superset/pull/38695#discussion_r3869143166
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts:
##########
@@ -84,6 +84,28 @@ export type EchartsMixedTimeseriesFormData = QueryFormData &
{
seriesTypeB: EchartsTimeseriesSeriesType;
showValue: boolean;
showValueB: boolean;
+ labelPosition?:
+ | 'auto'
+ | 'top'
+ | 'bottom'
+ | 'left'
+ | 'right'
+ | 'inside'
+ | 'insideTop'
+ | 'insideBottom'
+ | 'insideLeft'
+ | 'insideRight';
+ labelPositionB?:
+ | 'auto'
+ | 'top'
+ | 'bottom'
+ | 'left'
+ | 'right'
+ | 'inside'
+ | 'insideTop'
+ | 'insideBottom'
+ | 'insideLeft'
+ | 'insideRight';
Review Comment:
<!-- Bito Reply -->
The suggestion to align the `labelPosition` type definition with the
UI-supported options is appropriate. The current type definition includes
several 'inside*' variants that are not exposed in the `controlPanel.tsx`
configuration, which can lead to confusion or invalid selections. Aligning the
type with the actual UI capabilities improves type safety and consistency.
**superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts**
```
labelPosition?:
| 'auto'
| 'top'
| 'bottom'
| 'left'
| 'right'
| 'inside';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
