msyavuz opened a new pull request, #43587:
URL: https://github.com/apache/superset/pull/43587

   ### SUMMARY
   
   `lint-frontend` has failed on every master commit since #43553, and on every 
open PR, with 94 `import(no-named-as-default)` errors in files nobody touched.
   
   Cause: oxlint **1.79.0** (bumped in #43543) *implemented* 
`import/no-named-as-default`, which `oxlint.json` has set to `"error"` all 
along. The rule was a no-op before, so 94 pre-existing hits surfaced at once. 
Bisected against clean master:
   
   | oxlint | exit | `no-named-as-default` hits |
   |---|---|---|
   | 1.78.0 | 0 | 0 |
   | 1.79.0 | 1 | 94 |
   
   The 94 are not real defects. They're modules that intentionally export a 
symbol both as default and by name (`export const Foo` + `export default Foo`), 
plus upstream packages whose documented usage is a default import — 39 of the 
94 are `import configureStore from 'redux-mock-store'`, and others are `import 
$ from 'jquery'`, `import Chart from 'src/types/Chart'`. The rule exists to 
catch an *accidental* default import of a named-only export, which is not what 
it found here. Renaming 94 correct call sites to satisfy it would be churn, so 
the rule is downgraded to `"warn"`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — CI-only change, no UI.
   
   ### TESTING INSTRUCTIONS
   
   From `superset-frontend/`, against this branch:
   
   ```
   npx [email protected] --config oxlint.json --quiet ; echo $?   # 0 (was 1 on 
master)
   ```
   
   The 94 findings still appear as warnings without `--quiet`, so they stay 
visible.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue: No
   - [ ] Required feature flags: None
   - [ ] Changes UI: No — lint config only
   - [ ] Includes DB Migration: No
   - [ ] Introduces new feature or API: No
   - [ ] Removes existing feature or API: No — the rule still reports, at 
warning level


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to