codeant-ai-for-open-source[bot] commented on code in PR #43572:
URL: https://github.com/apache/superset/pull/43572#discussion_r3871552168
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -1045,6 +1045,70 @@ def reject_sql_expression_on_dimensions(self) ->
"PieChartConfig":
return self
+class BubbleChartConfig(BaseChartConfig):
+ """Config for bubble charts (viz_type ``bubble_v2``).
+
+ Matches the frontend Bubble buildQuery contract: an ``entity`` dimension
+ identifies each bubble, three separate metrics position and size it
+ (``x``, ``y``, ``size``), and an optional ``series`` dimension colours the
+ bubbles by group.
+ """
+
+ model_config = ConfigDict(extra="ignore", populate_by_name=True)
+
+ chart_type: Literal["bubble_v2"] = "bubble_v2"
+ entity: ColumnRef = Field(
+ ...,
+ description="Category column identifying each bubble (e.g. country)",
+ )
+ x: ColumnRef = Field(
+ ...,
+ description="Metric for the bubble's horizontal position (use "
+ "aggregate e.g. AVG, or saved_metric=True for a saved metric)",
+ )
+ y: ColumnRef = Field(
+ ...,
+ description="Metric for the bubble's vertical position",
+ )
+ size: ColumnRef = Field(
+ ...,
+ description="Metric for the bubble's area",
+ )
+ series: ColumnRef | None = Field(
+ None,
+ description="Optional category column colouring the bubbles by group",
+ )
+ row_limit: int = Field(10000, description="Max bubbles queried", ge=1,
le=100000)
+ filters: List[FilterConfig] | None = Field(
+ None,
+ description="Structured filters (column/op/value). "
+ "Do NOT use adhoc_filters or raw SQL expressions.",
+ )
+ color_scheme: str | None = Field(
+ None,
+ description=(
+ "Superset color scheme ID (e.g. 'supersetColors', 'lyftColors', "
+ "'googleCategory10c', 'd3Category10'). Defaults to
'supersetColors'."
+ ),
+ max_length=100,
+ )
+
+ @model_validator(mode="after")
+ def reject_metric_style_dimensions(self) -> "BubbleChartConfig":
+ """entity and series are dimensions, not metrics."""
+ dims = [(self.entity, "entity")]
+ if self.series is not None:
+ dims.append((self.series, "series"))
+ for col, name in dims:
+ _reject_sql_expression_on_dimension(col, name)
+ if col.saved_metric:
+ raise ValueError(
+ f"{name} cannot use saved_metric=True; "
+ "saved metrics belong in the 'x', 'y', or 'size' fields"
+ )
Review Comment:
**Suggestion:** The dimension validator rejects `sql_expression` and
`saved_metric`, but does not reject `aggregate`. Consequently, callers can
provide metric-style entity or series references such as `{"name": "country",
"aggregate": "SUM"}`; the mapper ignores that aggregate and emits only the
column name, silently changing the requested configuration. Reject aggregates
on these dimension fields as well. [incomplete implementation]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Bubble entity configuration silently drops supplied aggregates.
- ⚠️ Bubble series configuration silently drops supplied aggregates.
- ⚠️ Generated form data differs from the caller’s requested configuration.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e8c09eb5b35f43739236800f0a1b3d23&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e8c09eb5b35f43739236800f0a1b3d23&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/schemas.py
**Line:** 1099:1108
**Comment:**
*Incomplete Implementation: The dimension validator rejects
`sql_expression` and `saved_metric`, but does not reject `aggregate`.
Consequently, callers can provide metric-style entity or series references such
as `{"name": "country", "aggregate": "SUM"}`; the mapper ignores that aggregate
and emits only the column name, silently changing the requested configuration.
Reject aggregates on these dimension fields as well.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43572&comment_hash=97a608a37f853a474b94617bfe2a511c582c93604d0d39f659e36ea110a8a09e&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43572&comment_hash=97a608a37f853a474b94617bfe2a511c582c93604d0d39f659e36ea110a8a09e&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
