eugeneo17 commented on code in PR #43303:
URL: https://github.com/apache/superset/pull/43303#discussion_r3872702383
##########
superset-frontend/package.json:
##########
@@ -39,6 +39,7 @@
"scripts": {
"_format": "oxfmt
'./{src,spec,cypress-base,plugins,packages,.storybook}/**/*{.js,.jsx,.ts,.tsx,.css,.scss,.sass,.json}'",
"build": "cross-env NODE_OPTIONS=--max_old_space_size=8192
NODE_ENV=production BABEL_ENV=\"${BABEL_ENV:=production}\" webpack --color
--mode production",
+ "build:backend-querycontext": "node
scripts/build-backend-querycontext.mjs",
Review Comment:
Fair point, as it stands the exact-parity V8 path is effectively opt-in and
real deployments silently get the approximate builder. Two options and I would
like your steer:
a) Wire it into the supported flow: build the bundle as part of the frontend
build (committed or produced as a build artifact rather than gitignored) and
declare the V8 runtime as an explicit optional dependency, so exact parity is
the default.
b) Keep the approximate builder as the supported default and treat V8 as an
optional enhancement, but then document the accuracy gap (for example
mixed-timeseries losing its second query) and make the fallback deterministic.
My preference is a so imports do not silently degrade. If you agree I will
wire the bundle into the build and add the dependency in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
