hassan-webgains opened a new pull request, #43590: URL: https://github.com/apache/superset/pull/43590
### SUMMARY Follow-up to SUP-220 / #250 after Excel Convert-dialog feedback ([SUP-223](https://webgains.atlassian.net/browse/SUP-223)). - Continental CSV uses `;` as the column delimiter so values like `1.017,91` stay one numeric cell. US/GB keep `,`. - Charts and CSV keep `1,234.50` (en_US/en_GB) vs `1.234,50` (DE/ES/IT/NL/FR/PL). XLSX is still native numbers. - Embed `lang=en_GB` / `fr_FR` is enough; no short-lang map (`de` → `de_DE`) and no extra `locale` URL param required. - Removed the unused short-language lookup table from the previous approach. ### TESTING INSTRUCTIONS - Dashboard with `?locale=de_DE`: download CSV and open in Excel (German/Spanish region) without Convert. Confirm `;` separators and `1.017,91` as a number. - Embed with `urlParams.lang` only (`en_GB`, `fr_FR`, `de_DE`): chart numbers and CSV match that locale. - XLSX download still contains real numbers, not locale strings. - `Comm` cells like `1.00 EUR` stay as strings. ### ADDITIONAL INFORMATION - [x] Has associated issue: [SUP-223](https://webgains.atlassian.net/browse/SUP-223) (relates to SUP-220) - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
