rusackas commented on PR #42372: URL: https://github.com/apache/superset/pull/42372#issuecomment-5441666621
Nice diagnosis and fix on the grain-widening bug @DamianPendrak caught here. Wrapping the sort key in MIN() instead of stuffing it into columns seems right, and thanks for the tests covering it. @DamianPendrak mind confirming the fix now that it's in? Happy to get this merged once that's settled and CI's fully green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
