rusackas opened a new pull request, #43595:
URL: https://github.com/apache/superset/pull/43595

   ### SUMMARY
   Follow-up doc gap from #38831. That PR added the Subject/editor/viewer 
access model (`ENABLE_VIEWERS`, `SUBJECTS_RELATED_TYPES`, 
`VIEWER_PROMISCUOUS_MODE`, the owner→editor terminology shift), and most of it 
has since been documented in `docs/admin_docs/security/security.mdx` via 
follow-up PRs (#39440, #38829, #42951, #42472). The one config hook that never 
got written up is `EXTRA_EDITORS_RESOLVER`, which lets a deployment plug in 
externally-resolved editor subjects (e.g. a folder-permission system) that feed 
into `is_editor`/`raise_for_editorship`, save-as, and restore checks.
   
   This adds a subsection documenting what it does, how the resolver's return 
value is used, its interaction with the self-protection lockout-prevention 
logic, and its `extra_editors` surfacing in the chart/dashboard `GET` responses.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A — docs-only change.
   
   ### TESTING INSTRUCTIONS
   - Read the new "Extending Editorship with EXTRA_EDITORS_RESOLVER" subsection 
in `docs/admin_docs/security/security.mdx` and confirm it matches the behavior 
in `superset/security/manager.py` (`get_extra_editor_subject_ids`, `is_editor`) 
and `superset/commands/utils.py` (`_has_extra_editors_resolver`).
   - `pre-commit run --files docs/admin_docs/security/security.mdx` passes.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Co-Authored-By: Claude Sonnet 5 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to