codeant-ai-for-open-source[bot] commented on code in PR #43596:
URL: https://github.com/apache/superset/pull/43596#discussion_r3873468621
##########
docs/docs/using-superset/using-ai-with-superset.mdx:
##########
@@ -248,11 +248,12 @@ Ask your admin for the MCP server URL and any
authentication tokens you need.
### Datasets
-| Tool | Description |
-| ------------------------ | ------------------------------------------------ |
-| `list_datasets` | List datasets with filtering and search |
-| `get_dataset_info` | Get dataset metadata (columns, metrics, filters) |
-| `create_virtual_dataset` | Create a virtual dataset from a SQL query |
+| Tool | Description
|
+| ------------------------ |
----------------------------------------------------------------------------------------------
|
+| `list_datasets` | List datasets with filtering and search
|
+| `get_dataset_info` | Get dataset metadata (columns, metrics, filters)
|
Review Comment:
**Suggestion:** The `get_dataset_info` entry claims that the tool returns
dataset filters, but its response schema exposes columns and saved metrics and
has no dataset-level `filters` field. This can cause clients to rely on a
response property that is never produced; describe the returned column and
metric metadata instead, or document the actual filterable-column information.
[api mismatch]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ MCP clients may expect a nonexistent filters response field.
- โ ๏ธ Dataset discovery documentation misleads users about returned metadata.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7c6779cc0d1243719ee815dea418454d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7c6779cc0d1243719ee815dea418454d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/docs/using-superset/using-ai-with-superset.mdx
**Line:** 254:254
**Comment:**
*Api Mismatch: The `get_dataset_info` entry claims that the tool
returns dataset filters, but its response schema exposes columns and saved
metrics and has no dataset-level `filters` field. This can cause clients to
rely on a response property that is never produced; describe the returned
column and metric metadata instead, or document the actual filterable-column
information.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43596&comment_hash=e1ad4906e9643473ffb169dd010bb8c20836f01f617cf23129558edecbeb019c&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43596&comment_hash=e1ad4906e9643473ffb169dd010bb8c20836f01f617cf23129558edecbeb019c&reaction=dislike'>๐</a>
##########
docs/docs/using-superset/using-ai-with-superset.mdx:
##########
@@ -248,11 +248,12 @@ Ask your admin for the MCP server URL and any
authentication tokens you need.
### Datasets
-| Tool | Description |
-| ------------------------ | ------------------------------------------------ |
-| `list_datasets` | List datasets with filtering and search |
-| `get_dataset_info` | Get dataset metadata (columns, metrics, filters) |
-| `create_virtual_dataset` | Create a virtual dataset from a SQL query |
+| Tool | Description
|
+| ------------------------ |
----------------------------------------------------------------------------------------------
|
+| `list_datasets` | List datasets with filtering and search
|
+| `get_dataset_info` | Get dataset metadata (columns, metrics, filters)
|
+| `create_virtual_dataset` | Create a virtual dataset from a SQL query
|
+| `update_dataset_metric` | Update a saved metric's expression, name,
verbose_name, or format (requires dataset ownership) |
Review Comment:
**Suggestion:** The description does not warn that updating a saved metric
changes the reusable metric definition for every chart that references it.
Because this is a destructive, dataset-wide operation rather than a local chart
edit, clients may perform an apparently narrow expression or formatting change
and unintentionally alter many existing charts; include the operation's
cross-chart impact in the reference. [security]
<details>
<summary><b>Severity Level:</b> Major โ ๏ธ</summary>
```mdx
- โ ๏ธ Shared metric edits can alter multiple existing charts.
- โ Metric expression changes can change chart results unexpectedly.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0589af942e55453784dfc8ee75238480&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0589af942e55453784dfc8ee75238480&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/docs/using-superset/using-ai-with-superset.mdx
**Line:** 256:256
**Comment:**
*Security: The description does not warn that updating a saved metric
changes the reusable metric definition for every chart that references it.
Because this is a destructive, dataset-wide operation rather than a local chart
edit, clients may perform an apparently narrow expression or formatting change
and unintentionally alter many existing charts; include the operation's
cross-chart impact in the reference.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43596&comment_hash=759dd66f1199a4e1ce38580f557a3a1d68834f02214bf1432373678a482fde5d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43596&comment_hash=759dd66f1199a4e1ce38580f557a3a1d68834f02214bf1432373678a482fde5d&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
