bito-code-review[bot] commented on code in PR #43600:
URL: https://github.com/apache/superset/pull/43600#discussion_r3875340263
##########
docs/docs/using-superset/embedding.mdx:
##########
@@ -88,6 +88,19 @@ embedDashboard({
If the callback returns `null` or is not provided, Superset uses its own
permalink URL as a fallback.
+### Permalink origin rewriting
+
+Separately from `resolvePermalinkUrl`, Superset itself rewrites the origin of
any permalink URL it generates to `window.location.origin` before showing it to
the user. This keeps a proxied or subdirectory-deployed Superset from handing
out a permalink that points at an internal hostname the user's browser can't
reach.
Review Comment:
<!-- Bito Reply -->
The suggestion provided by the reviewer is accurate. The documentation
change correctly clarifies that the origin rewrite is a fallback mechanism
specifically for non-embedded permalinks, and that the
`EMBEDDED_DISABLE_PERMALINK_ORIGIN_REWRITE` flag only impacts that specific
path, rather than applying globally to embedded permalinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
