aminghadersohi commented on code in PR #43480: URL: https://github.com/apache/superset/pull/43480#discussion_r3875555193
########## superset/mcp_service/chart/plugins/interactive_pivot.py: ########## @@ -0,0 +1,226 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""AG Grid interactive pivot chart plugin.""" + +from __future__ import annotations + +from collections.abc import Mapping +from typing import Any, ClassVar + +from superset.extensions import feature_flag_manager +from superset.mcp_service.chart.chart_utils import ( + _add_adhoc_filters, + _summarize_filters, + add_currency_format, + create_metric_object, +) +from superset.mcp_service.chart.plugin import BaseChartPlugin +from superset.mcp_service.chart.schemas import ColumnRef, InteractivePivotChartConfig +from superset.mcp_service.chart.validation.dataset_validator import DatasetValidator +from superset.mcp_service.common.error_schemas import ChartGenerationError + +INTERACTIVE_PIVOT_FEATURE_FLAG = "AG_GRID_PIVOT_TABLE_ENABLED" +_AG_GRID_AGGREGATION = { + "AVG": "avg", + "MIN": "min", + "MAX": "max", +} + + +def _metric_label(metric: dict[str, Any] | str) -> str: + """Return the label AG Grid uses as a metric column identifier.""" + return metric if isinstance(metric, str) else str(metric["label"]) + + +def _grid_aggregation(metric: ColumnRef) -> str: + """Map a Superset metric aggregate to AG Grid's group rollup function.""" + return _AG_GRID_AGGREGATION.get((metric.aggregate or "SUM").upper(), "sum") + + +def map_interactive_pivot_config( + config: InteractivePivotChartConfig, +) -> dict[str, Any]: + """Map the MCP config to ``ag-grid-pivot-table`` form data.""" + metrics = [create_metric_object(metric) for metric in config.metrics] + rows = [column.name for column in config.rows] + columns = [column.name for column in config.columns] + + form_data: dict[str, Any] = { + "viz_type": "ag-grid-pivot-table", + # The control panel stores every dimension in groupby. AG Grid's + # persisted state assigns each one to the Rows or Column Labels bucket. + "groupby": [*rows, *columns], + "metrics": metrics, + "row_limit": config.row_limit, + "order_desc": config.sort_descending, + "rowGroupCounts": config.show_row_group_counts, + "rowTotals": config.show_row_totals, + "colTotals": config.show_column_totals, + "colSubTotals": config.show_column_subtotals, + "valueFormat": config.value_format, + "allow_render_html": config.allow_render_html, + "expand_pivot_groups": config.expand_pivot_groups, + "pivot_table_state": { + "rowGroup": {"groupColIds": rows}, + "pivot": {"pivotMode": True, "pivotColIds": columns}, + "aggregation": { + "aggregationModel": [ + { + "colId": _metric_label(mapped_metric), + "aggFunc": _grid_aggregation(metric), + } + for metric, mapped_metric in zip( + config.metrics, metrics, strict=True + ) + ] + }, + }, + } + + if config.temporal_column: + form_data["granularity_sqla"] = config.temporal_column + form_data["temporal_columns_lookup"] = {config.temporal_column: True} Review Comment: Fixed in 9a7c7d11e6. The Interactive Pivot plugin now canonicalizes `temporal_column` with the same dataset helper used for its row/column refs before form-data mapping. Added a regression test covering mixed-case input and asserting canonical `groupby`, `granularity_sqla`, and `temporal_columns_lookup` values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
