codeant-ai-for-open-source[bot] commented on code in PR #43627: URL: https://github.com/apache/superset/pull/43627#discussion_r3876981919
########## tests/unit_tests/tasks/test_scheduler_executor.py: ########## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Unit tests for the GTF executor body (scheduler._execute_task_body).""" + +from types import SimpleNamespace +from unittest.mock import MagicMock, patch +from uuid import uuid4 + +from superset_core.tasks.types import TaskStatus + + +def _run_body_with_raising_executor(*, timeout_triggered: bool, abort_detected: bool): + """Drive _execute_task_body where the task body raises mid-abort/timeout. + + Returns ``(result, transition_mock, task_manager_mock, stats_logger_mock)`` for + the caller to assert on the terminal handling. + """ + native = uuid4() + task = SimpleNamespace( + uuid=native, + status=TaskStatus.PENDING.value, + properties_dict={}, # no "timeout" key -> no timeout timer started + ) + # What the finally block's terminal transition commits, read back at the end. + refreshed = SimpleNamespace( + status=( + TaskStatus.TIMED_OUT.value + if timeout_triggered + else TaskStatus.ABORTED.value + ) + ) Review Comment: **Suggestion:** The refreshed ORM stub is initialized with the expected terminal status before `_execute_task_body` runs, so the result assertion can pass even if the implementation never issues the required `TIMED_OUT`/`ABORTED` transition. Assert that the transition mock was called with the corresponding terminal status (and expected state) to make this regression test verify finalization rather than merely echoing the fixture. [incomplete implementation] <details> <summary><b>Severity Level:</b> Minor ๐งน</summary> ```mdx - โ ๏ธ Timeout regression test can pass without finalizing tasks. - โ ๏ธ Abort regression test has the same unverified transition. - โ ๏ธ CI may miss tasks stuck in ABORTING. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=be87468fc66e4c6e94505b3f89ae60a5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=be87468fc66e4c6e94505b3f89ae60a5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/tasks/test_scheduler_executor.py **Line:** 39:45 **Comment:** *Incomplete Implementation: The refreshed ORM stub is initialized with the expected terminal status before `_execute_task_body` runs, so the result assertion can pass even if the implementation never issues the required `TIMED_OUT`/`ABORTED` transition. Assert that the transition mock was called with the corresponding terminal status (and expected state) to make this regression test verify finalization rather than merely echoing the fixture. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43627&comment_hash=0dff2a2def45b0481c0752b447b65fc6ee84d650f1a5001ef18746b168e7f906&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43627&comment_hash=0dff2a2def45b0481c0752b447b65fc6ee84d650f1a5001ef18746b168e7f906&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
