rusackas commented on PR #39386: URL: https://github.com/apache/superset/pull/39386#issuecomment-5448093912
Thanks for adding the logging and the test, @bouhalimedaziz, this looks right now. Two things blocking green/merge though: it's showing conflicts against master, so it needs a rebase, and lint-check is failing because the title doesn't match the conventional-commit format (needs something like `fix: handle missing table element in downloadAsPivotExcel`). Can you rebase and tweak the title? Let me know if you want a hand with any of it. If I don't hear back in a while, I might jump in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
