rusackas commented on PR #40815: URL: https://github.com/apache/superset/pull/40815#issuecomment-5448102850
@msyavuz this looks better now! Thanks for cleaning up the `any` casts and the stale-allowlist race from my last pass. This still says "Fixes #43258", but per your reply to @mikemazara this PR only covers the RLS leak, not the dashboard-filter/25-cap issue #43258 is actually about. Mind dropping that closing link so merging doesn't quietly close it out from under his follow-up? Also never got your take on whether the embedded guest role actually has `can_get_column_values` on `Datasource` by default. That's the case this PR is tackling, so I wanted to make sure it isn't just going to render the "unable to verify" message for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
