codeant-ai-for-open-source[bot] commented on code in PR #43638:
URL: https://github.com/apache/superset/pull/43638#discussion_r3877847261
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -240,6 +240,40 @@ Font URLs are validated against a configurable allowlist.
By default, fonts from
This feature works with the stock Docker image - no custom build required!
+## Results Grid Configuration Overrides
+
+Superset exposes a handful of opt-in tokens that customize the appearance of
+AG Grid-backed result tables, such as the results grid in SQL Lab. These
+tokens have no effect unless explicitly set, since the results grid otherwise
+falls back to its built-in defaults.
+
+```python
+THEME_DEFAULT = {
+ "token": {
+ "colorPrimary": "#2893B3",
+ # ... other Ant Design tokens
+
+ # Results grid overrides
+ "resultsGridRowHeight": 32,
+ "resultsGridHeaderFontSize": 13,
+ "resultsGridHeaderFontWeight": 600,
+ "resultsGridBorderRadius": 4,
+ "resultsGridNoStriping": True,
+ }
+}
+```
+
+| Token | Type | Description |
+| --- | --- | --- |
+| `resultsGridRowHeight` | `number` | Row and header height, in pixels. |
+| `resultsGridHeaderFontSize` | `number` | Header cell font size, in pixels. |
+| `resultsGridHeaderFontWeight` | `number` | Header cell font weight. |
+| `resultsGridBorderRadius` | `number` | Border radius applied to the grid and
its wrapper, in pixels. |
Review Comment:
**Suggestion:** The description claims this token applies the border radius
to both the grid and its wrapper, but the implementation only passes
`borderRadius` to AG Grid; `wrapperBorderRadius` has no consumer and therefore
does not style the outer wrapper. Remove the wrapper claim or document the
behavior only after adding wrapper styling. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ SQL Lab grid wrapper ignores documented radius.
- ⚠️ Customized grid corners may not match surrounding layout.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9a9a06a3990d44e7bd8f3e86d7bd17ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9a9a06a3990d44e7bd8f3e86d7bd17ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/admin_docs/configuration/theming.mdx
**Line:** 271:271
**Comment:**
*Api Mismatch: The description claims this token applies the border
radius to both the grid and its wrapper, but the implementation only passes
`borderRadius` to AG Grid; `wrapperBorderRadius` has no consumer and therefore
does not style the outer wrapper. Remove the wrapper claim or document the
behavior only after adding wrapper styling.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43638&comment_hash=d2fde4219106b2a2359a5967e2fbaa0146a9e8ceccc94e8ac7f9a79750bcc174&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43638&comment_hash=d2fde4219106b2a2359a5967e2fbaa0146a9e8ceccc94e8ac7f9a79750bcc174&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
