rusackas commented on PR #43193: URL: https://github.com/apache/superset/pull/43193#issuecomment-5448314081
@bikash-barnwal the category-axis part of this looks right, but I don't think it closes #36325. ECharts only reads `axisLabel.interval` on category axes (`axisTickLabelBuilder.js` routes to `makeCategoryLabels` there); on a time axis, which is what the issue title is actually about, label placement comes from the generated ticks and `minInterval`, and never touches this option. Superset sets `xAxis.type` to `AxisType.Time` whenever the x-axis column is temporal, so the scenario people are reporting (day/week grain on a temporal column) goes through the code path this PR doesn't change. The new regression test in `test/Timeseries/transformProps.test.ts` still uses the base fixture's `coltypes: []`, so it's exercising the category path where this already worked, not the temporal one from the report. Worth adding a case with a temporal coltype and a time grain to prove the fix actually does something there, or scoping the PR title/description to what it really covers. Also needs a rebase, this is showing conflicts with `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
