SEPURI-SAI-KRISHNA commented on PR #43205: URL: https://github.com/apache/superset/pull/43205#issuecomment-5450511249
Gentle nudge on this one — it's been open since Aug 15 without a first review. It's the smallest change in this area I have open: +54/-0 across two files, 46 of which are tests. No behaviour change beyond the added mappings. `PROPHET_TIME_GRAIN_MAP` holds 16 keys against 19 built-in time grains, so `PT5S`, `PT30S` and `PT6H` pass schema validation and then fail inside `prophet()`. This brings the map to 21 keys, making it a superset of the built-ins. That last part also unblocks #43356: deriving the published `time_grain` choices from the map is only safe once the map covers every built-in grain, otherwise those three silently drop out of the spec. CI is green (62 passing). No urgency — happy to rebase or split if that helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
