aminghadersohi commented on PR #43623:
URL: https://github.com/apache/superset/pull/43623#issuecomment-5454897859

   Addressed the open OAuth review feedback in 035cdd35c4:
   
   - A forced refresh with no refresh token durably commits deletion from the 
isolated token session.
   - `invalid_grant` remains a permanent refresh rejection and raises 
`OAuth2TokenRefreshError`; the parser uses the JSON body with a text fallback 
for compatible provider/test response shapes.
   - Transient or ambiguous provider errors remain non-terminal and preserve 
the stored refresh token.
   
   Verification: the previously failing GSheets test passes, 189 related unit 
tests pass, and pre-commit passes for all changed files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to