mikebridge commented on code in PR #43629:
URL: https://github.com/apache/superset/pull/43629#discussion_r3882918983
##########
superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx:
##########
@@ -412,6 +412,9 @@ const AsyncSelect = forwardRef(
setIsLoading(false);
return;
}
+ // A previous fetch may have left an error on screen; clear it so the
+ // dropdown renders this fetch's outcome instead of the stale error.
+ setError('');
Review Comment:
Confirmed — `setError('')` sat after the `allValuesLoaded` /
`fetchedQueries` early returns, so a page served from cache kept the previous
error on screen. Moved it to the top of `fetchPage` in db0e80894a, with a test
that fails against the old placement (`clears a previous fetch error when the
next page comes from cache`).
_Reply generated by Claude (AI) on behalf of @mikebridge._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
