sadpandajoe commented on code in PR #43512:
URL: https://github.com/apache/superset/pull/43512#discussion_r3883541978
##########
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx:
##########
@@ -935,7 +939,7 @@ test('filters the subject select by column verbose_name as
well as column_name',
});
Review Comment:
This v14 migration still leaves the later comparator interactions in this
file unawaited (`openComparator` and its callers). A following assertion or
action can run before the control is open or typed, making those tests flaky
under slower scheduling. Could those interactions be awaited as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
