bito-code-review[bot] commented on PR #43654:
URL: https://github.com/apache/superset/pull/43654#issuecomment-5457272667
<!-- Bito Reply -->
Adding tests for `decimal(12)` and `decimal` is a good idea to ensure
comprehensive coverage of the `DECIMAL` type coercion logic. Since the current
implementation in `TrinoEngineSpec` uses `sqlalchemy.types.DECIMAL` to identify
columns for coercion, testing these variations will confirm that the logic
correctly handles different `DECIMAL` type definitions as expected by the
SQLAlchemy reflection.
**tests/unit_tests/db_engine_specs/test_trino.py**
```
(
[["1.846619834", "abc"]],
[("dec", "decimal(12)"), ("str", "varchar(3)")],
[(Decimal("1.846619834"), "abc")],
),
(
[["1.846619834", "abc"]],
[("dec", "decimal"), ("str", "varchar(3)")],
[(Decimal("1.846619834"), "abc")],
),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
