mikebridge commented on PR #42839:
URL: https://github.com/apache/superset/pull/42839#issuecomment-5457383335

   Rebased onto master `0eda633b45` (547 commits; clean, no conflicts). One 
master change overlapped semantically rather than textually: #43389 added 
access checks and 403 docs across the semantic-layer endpoints. This branch 
adds no route — it extends the existing `structure` endpoint, whose 
`view.raise_for_access()` (pre-existing, now at api.py:233) runs before the new 
`description`/`cache_timeout` fields are returned, so the hydration data stays 
behind the same check. Verified after rebase: 
`tests/unit_tests/semantic_layers/api_test.py` 96/96, 
`SemanticViewEditModal.test.tsx` 17/17, mypy/ruff/oxlint/tsc clean over the 
range. Head `a2991e1393`; CI restarting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to