sadpandajoe commented on code in PR #43652: URL: https://github.com/apache/superset/pull/43652#discussion_r3883910202
########## requirements/development.in: ########## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # --e .[development,bigquery,cockroachdb,crate,druid,duckdb,elasticsearch,fastmcp,gevent,gsheets,monetdb,mongodb,mssql,mysql,oracle,postgres,presto,prophet,trino,thumbnails] +-e .[development,bigquery,clickhouse,cockroachdb,crate,druid,duckdb,elasticsearch,fastmcp,gevent,gsheets,monetdb,mongodb,mssql,mysql,oracle,postgres,presto,prophet,starrocks,trino,thumbnails] Review Comment: Adding this extra to the baseline makes importing `superset.db_engine_specs.clickhouse` crash outside a Flask application context: the newly installed connector lets module import reach `app.config` at line 371, whereas the existing ImportError guard previously bypassed it. That affects development scripts or tests that import engine specs without constructing the app. Could this be installed only for the ClickHouse CI leg, or could the module-level setting be made app-context safe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
