codeant-ai-for-open-source[bot] commented on code in PR #39658:
URL: https://github.com/apache/superset/pull/39658#discussion_r3880033930
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx:
##########
@@ -243,6 +243,13 @@ export default typedMemo(function DataTable<D extends
object>({
},
...tableHooks,
);
+ // Clamp pageIndex when filtered data shrinks below current view (#31403)
+ if (data.length > 0 && pageCount > 0 && pageIndex >= pageCount) {
+ gotoPage(pageCount - 1);
+ } else if (pageCount === 0 && pageIndex !== 0) {
+ gotoPage(0);
+ }
Review Comment:
**Suggestion:** Calling `gotoPage` during render dispatches a react-table
state update before the current render completes. When filtering or changing
data leaves `pageIndex` out of range, this causes render-phase state updates
and an additional render, and can produce React warnings or repeated render
cycles. Move the clamping into a `useEffect` keyed by `pageCount`, `pageIndex`,
and the relevant data state so the update occurs after commit. [state/lifecycle]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Client-side table filtering triggers render-phase pagination updates.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6db9c3fa983146a295171218ccc69f57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6db9c3fa983146a295171218ccc69f57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx
**Line:** 246:251
**Comment:**
*State Lifecycle: Calling `gotoPage` during render dispatches a
react-table state update before the current render completes. When filtering or
changing data leaves `pageIndex` out of range, this causes render-phase state
updates and an additional render, and can produce React warnings or repeated
render cycles. Move the clamping into a `useEffect` keyed by `pageCount`,
`pageIndex`, and the relevant data state so the update occurs after commit.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39658&comment_hash=c71b83879f5cdfd61cd93453c58ca55ebe938da5cf1a20fc013e62daab34f843&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39658&comment_hash=c71b83879f5cdfd61cd93453c58ca55ebe938da5cf1a20fc013e62daab34f843&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
