codeant-ai-for-open-source[bot] commented on code in PR #43666:
URL: https://github.com/apache/superset/pull/43666#discussion_r3884833357
##########
superset/commands/dashboard/update.py:
##########
@@ -130,6 +131,19 @@ def validate(self) -> None:
except ValidationError as ex:
exceptions.append(ex)
+ # A dashboard PUT resends the full object on every save, so only
+ # validate css when it's actually changing -- otherwise a dashboard
+ # whose existing css predates this check (or was imported without
+ # going through it) becomes uneditable for unrelated changes like a
+ # rename or a chart move.
+ if "css" in self._properties:
+ new_css = self._properties["css"]
+ if new_css != self._model.css:
+ try:
+ validate_css(new_css)
Review Comment:
**Suggestion:** The comparison and validation occur before
`DashboardDAO.update` without locking or rechecking the row. If another request
changes the stored CSS after this command reads `self._model.css` but before
the update, an unrelated edit can skip validation and then write the stale,
potentially dangerous `new_css` back over the concurrent safe value. Perform
the comparison and write under a row lock or otherwise enforce the check
atomically at update time. [race condition]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Concurrent dashboard saves can restore dangerous persisted CSS.
- ❌ Custom CSS validation can be bypassed through stale full-object writes.
- ⚠️ Subsequent dashboard renders receive the reintroduced CSS.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=918ae11c04c54e2584ca095e86b99d0c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=918ae11c04c54e2584ca095e86b99d0c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/dashboard/update.py
**Line:** 139:143
**Comment:**
*Race Condition: The comparison and validation occur before
`DashboardDAO.update` without locking or rechecking the row. If another request
changes the stored CSS after this command reads `self._model.css` but before
the update, an unrelated edit can skip validation and then write the stale,
potentially dangerous `new_css` back over the concurrent safe value. Perform
the comparison and write under a row lock or otherwise enforce the check
atomically at update time.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43666&comment_hash=6ef56a4c617eb680170cf7ba9d0f41f083750f07bfca851026a7f912279d5c1a&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43666&comment_hash=6ef56a4c617eb680170cf7ba9d0f41f083750f07bfca851026a7f912279d5c1a&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
