bito-code-review[bot] commented on PR #43669: URL: https://github.com/apache/superset/pull/43669#issuecomment-5460402887
<!-- Bito Reply --> The flagged issue is correct. The current spacing calculation uses a simplified width (`width - 2 * TIMESERIES_CONSTANTS.gridOffsetLeft`) which ignores additional ECharts layout elements like y-axis titles, legends, and padding, leading to an overestimation of available space and potential label overlap. To resolve this, you should calculate the effective grid width by accounting for these additional margins. In `transformProps.ts`, you can access these values from the chart props or ECharts configuration and subtract them from the total width before passing the value to `createSpacedXAxisFormatter`. Would you like me to fetch all other comments on this PR to validate and implement fixes for them as well? **superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts** ``` Math.max(width - 2 * TIMESERIES_CONSTANTS.gridOffsetLeft, 0), ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
