yiheng-kkk opened a new pull request, #43682:
URL: https://github.com/apache/superset/pull/43682

   ### SUMMARY
   
   Addresses item 1 of #43547.
   
   Pandas drops null grouping keys by default, so grouped Histogram and Box 
Plot post-processing silently omitted those categories. This passes 
`dropna=False` in the shared aggregate path and the grouped Histogram path, 
with deterministic regressions for both behaviors.
   
   This PR is intentionally limited to the missing-group issue. It does not 
address the separate frontend `NULL_STRING` label and tooltip inconsistencies 
reported in items 2 and 3.
   
   AI assistance disclosure: OpenAI Codex assisted with repository and 
competition auditing, implementation, test preparation, and validation. The 
change was independently reviewed and validated against the repository's locked 
Python dependencies.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable; the change is limited to backend DataFrame post-processing 
and is covered by deterministic output assertions.
   
   ### TESTING INSTRUCTIONS
   
   - `.venv/bin/pytest -q 
tests/unit_tests/pandas_postprocessing/test_aggregate.py 
tests/unit_tests/pandas_postprocessing/test_histogram.py 
tests/unit_tests/pandas_postprocessing/test_boxplot.py` (25 passed)
   - `.venv/bin/pytest -q tests/unit_tests/pandas_postprocessing` (142 passed)
   - `PATH="$PWD/.venv/bin:$PATH" .venv/bin/pre-commit run` (all applicable 
staged hooks passed)
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: #43547 (item 1 only)
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to