gkneighb commented on PR #43573: URL: https://github.com/apache/superset/pull/43573#issuecomment-5463607162
@aminghadersohi — correction on my round-2 fix: you're right that the `orderby` I'd stashed in `form_data` was a no-op. `_build_single_query_dict` never reads a top-level `orderby` (only the `deck_*` path does), which your funnel review made clear. Fixed properly in `b5682e877e`: - Removed the no-op `form_data["orderby"]` emission from `map_sankey_config`. - Emit `orderby` in the shared `_build_single_query_dict` when `sort_by_metric` is set, so the metric ordering actually reaches the query (this covers pie/funnel/treemap by the same path). - Replaced the mapper-level assertion with a query-context test: `build_query_dicts_from_form_data(...)` now yields `columns=['from_stage','to_stage']` **and** a descending metric `orderby`. The GROUP BY fix from round 2 stands; this closes the ordering half. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
