bito-code-review[bot] commented on code in PR #43686:
URL: https://github.com/apache/superset/pull/43686#discussion_r3887257045
##########
superset-frontend/scripts/check-storybook-coverage.js:
##########
@@ -117,7 +120,7 @@ function main() {
for (const pluginDir of pluginDirs) {
const fullPath = path.join(ROOT, pluginDir);
- if (!fs.existsSync(fullPath)) continue;
+ if (!fs.existsglob.sync(fullPath)) continue;
const pluginName = getPluginName(pluginDir);
Review Comment:
<!-- Bito Reply -->
The suggestion provided by the reviewer is correct and appropriate to apply.
The `fs.existsglob` method does not exist in the Node.js `fs` module, and using
`fs.existsSync(fullPath)` is the standard and correct way to check for a file's
existence in this context, preventing the runtime error described.
**superset-frontend/scripts/check-storybook-coverage.js**
```
for (const pluginDir of pluginDirs) {
const fullPath = path.join(ROOT, pluginDir);
if (!fs.existsSync(fullPath)) continue;
const pluginName = getPluginName(pluginDir);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
