bito-code-review[bot] commented on PR #43685:
URL: https://github.com/apache/superset/pull/43685#issuecomment-5463269145
<!-- Bito Reply -->
The flagged issue is correct. The original implementation sent a `/cancel`
request immediately upon any abort, which could prematurely terminate a shared
task still needed by other charts in the same browser session. The provided
diff already implements a fix by introducing `cancelUnwaitedTasks`, which
checks if any other local waiters still depend on the task before sending the
cancellation request. This ensures that shared tasks are only cancelled when no
local waiters remain. No further action is required for this specific issue.
**superset-frontend/src/middleware/asyncEvent.ts**
```
const cancelUnwaitedTasks = (taskIds: string[]) => {
taskIds.forEach(taskId => {
if (!waitersByTaskId.has(taskId)) cancelTask(taskId);
});
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
