gabotorresruiz commented on PR #43340: URL: https://github.com/apache/superset/pull/43340#issuecomment-5464293462
Thanks Elizabeth! Content-Length added in 5da2b3620a with the shape you suggested: download() now returns (size, chunks) as a small NamedTuple, S3 reads ContentLength off the get_object call it already makes, and GCS does one blob.reload() that doubles as an eager existence check, which also let me drop the first chunk pull trick from the endpoint. Integration test asserts the header. On the nits: agreed the empty object case is unreachable (every export carries at least the summary sheet), and the dashboard title filename is a nice follow up since the job record would need to carry the title; leaving both as is for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
