codeant-ai-for-open-source[bot] commented on code in PR #43690:
URL: https://github.com/apache/superset/pull/43690#discussion_r3887849280
##########
docs/developer_docs/extensions/components/index.mdx:
##########
@@ -47,8 +47,8 @@ export function MyExtensionPanel() {
Components in `@apache-superset/core/components` are automatically documented
here. To add a new extension component:
-1. Add the component to
`superset-frontend/packages/superset-core/src/ui/components/`
-2. Export it from
`superset-frontend/packages/superset-core/src/ui/components/index.ts`
+1. Add the component to
`superset-frontend/packages/superset-core/src/components/`
+2. Export it from
`superset-frontend/packages/superset-core/src/components/index.ts`
Review Comment:
**Suggestion:** The new instructions point contributors to
`src/components/`, but the current extension development guide still says
extension-compatible components must be placed under the removed
`src/ui/components/` path. This leaves the live documentation contradictory and
can cause contributors following the broader guide to create components where
the package no longer discovers or exports them. Update the companion
development guide in the same change, or otherwise make the documentation
consistently reference the current path. [incomplete implementation]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Live extension guide gives obsolete component location.
- ❌ New components may be omitted from package exports.
- ⚠️ Contributor documentation remains inconsistent across entry points.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0bf2ff02c9bb4e1794695116db9f7d9f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0bf2ff02c9bb4e1794695116db9f7d9f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/developer_docs/extensions/components/index.mdx
**Line:** 50:51
**Comment:**
*Incomplete Implementation: The new instructions point contributors to
`src/components/`, but the current extension development guide still says
extension-compatible components must be placed under the removed
`src/ui/components/` path. This leaves the live documentation contradictory and
can cause contributors following the broader guide to create components where
the package no longer discovers or exports them. Update the companion
development guide in the same change, or otherwise make the documentation
consistently reference the current path.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43690&comment_hash=f5dc6ff8eb2cb5ad819c0d68d1a699348b5e332c726a737b33f2b7f25d304c70&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43690&comment_hash=f5dc6ff8eb2cb5ad819c0d68d1a699348b5e332c726a737b33f2b7f25d304c70&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
