omsn2 commented on code in PR #43108:
URL: https://github.com/apache/superset/pull/43108#discussion_r3888663729
##########
superset-frontend/src/dashboard/containers/DashboardPage.tsx:
##########
@@ -334,7 +404,7 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }:
PageProps) => {
}
if (id) getDataMaskApplied();
// eslint-disable-next-line react-hooks/exhaustive-deps
- }, [readyToRender]);
+ }, [readyToRender, id]);
Review Comment:
Great catch. Fixed in the latest commit by adding an early return if
(!readyToRender) { return null; } at the top of getDataMaskApplied. This
guarantees that the URL rewrite (which strips matched f= params) and Rison
injection are fully deferred until both the dashboard and charts are ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
