codeant-ai-for-open-source[bot] commented on code in PR #43692:
URL: https://github.com/apache/superset/pull/43692#discussion_r3889789614
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx:
##########
@@ -332,40 +337,68 @@ export const FormattingPopoverContent = ({
);
const handleObjectChange = (value: ObjectFormattingEnum) => {
- setObjectFormatting(value);
-
if (value === ObjectFormattingEnum.CELL_BAR) {
const currentColumnValue = form.getFieldValue('columnFormatting');
const isCurrentColumnNumeric = numericColumns.some(
col => col.value === currentColumnValue,
);
- if (!isCurrentColumnNumeric && numericColumns.length > 0) {
+ if (
+ !isCurrentColumnNumeric &&
+ numericColumns.length > 0 &&
+ !applyToWholeRow
+ ) {
const newValue = numericColumns[0]?.value || '';
form.setFieldsValue({
columnFormatting: newValue,
});
- setColumnFormatting(newValue);
}
}
};
- const getColumnOptions = useCallback(
- () =>
+ const handleWholeRowChange = (checked: boolean) => {
+ setApplyToWholeRow(checked);
+ // The field is kept in sync for display (the disabled select shows the
+ // "entire row" label); handleFinish derives the submitted value from
+ // the checkbox
+ form.setFieldsValue({
+ columnFormatting: checked
+ ? ObjectFormattingEnum.ENTIRE_ROW
+ : (lastColumnRef.current ??
+ allColumns.find(item => item.value === column)?.value),
+ });
Review Comment:
**Suggestion:** After the formatting-column select changes, `lastColumnRef`
remains stale. Unchecking whole-row mode therefore restores the old column or
the condition column, silently saving the wrong formatting target. [stale
reference]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=592cd5d8ce124991ad32aace7616a663&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=592cd5d8ce124991ad32aace7616a663&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx
**Line:** 366:370
**Comment:**
*Stale Reference: After the formatting-column select changes,
`lastColumnRef` remains stale. Unchecking whole-row mode therefore restores the
old column or the condition column, silently saving the wrong formatting target.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43692&comment_hash=73be76f15891b1e3314a3b012ecdaa39c5b2d95bdd16c819823abb69a1829bdd&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43692&comment_hash=73be76f15891b1e3314a3b012ecdaa39c5b2d95bdd16c819823abb69a1829bdd&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
