rusackas commented on PR #43620: URL: https://github.com/apache/superset/pull/43620#issuecomment-5470902863
@sakshipatil-hue thanks for digging into this one! Unfortunately it looks like #43549 landed the same fix a couple of days ago, so after this branch caught up with `master`, the remaining diff is a refactor of already-fixed logic, and the two new tests duplicate ones that exist earlier in the same file (same titles, even). We may want to close this one in favor of the earlier fix... sorry for the near-miss. Holler if you spot something the merged version still gets wrong! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
