sadpandajoe commented on code in PR #43696:
URL: https://github.com/apache/superset/pull/43696#discussion_r3890798028
##########
superset-frontend/src/middleware/asyncEvent.ts:
##########
@@ -275,8 +297,10 @@ const loadStatusChanges = async (generation: number) => {
// Start (or wake) the poll loop for a freshly registered waiter: poll eagerly
// again, and kick the loop if it had gone idle. Idempotent — a no-op while the
-// loop is already running or when async queries are disabled.
+// loop is already running, when async queries are disabled, or when the
websocket
+// is the transport (WS mode never polls; reconnect catch-up reconciles
instead).
const ensurePolling = () => {
+ if (wsEnabled) return;
Review Comment:
This disables the correctness backstop whenever WebSocket is enabled: Redis
Pub/Sub can lose a `task.status` message while the socket remains open, so no
reconnect catch-up runs and a completed chart task eventually fails only at the
timeout. Should the recurring status check remain available while there are
pending waiters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
