eschutho commented on PR #43723: URL: https://github.com/apache/superset/pull/43723#issuecomment-5481289364
@kgabryje — routing this to you as our frontend-plugins reviewer. It renames the deprecated `groupby:` key to `columns:` in 16 example chart YAMLs, scoped to **`table` (8)** and **`pie` (8)** only. The whole safety argument lives in frontend query construction: the author's self-review already reverted `echarts_timeseries_line`/`echarts_area`/`treemap_v2` because those `buildQuery.ts` read `formData.groupby` directly (Timeseries feeds `series_columns`, Treemap drives `orderby`), whereas `table`/`pie` never touch it. The value-add here is a second pair of eyes confirming no *included* viz_type silently drops its grouping dimension. Thanks 🦉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
