sfirke commented on PR #43722: URL: https://github.com/apache/superset/pull/43722#issuecomment-5481063549
Re: the bot review comments about the blank line — validated and addressed in 6eed0d4. The concern is real: a trailing blank line turns a tight Markdown list loose (`<li>a</li>` → `<li><p>a</p></li>`), which would affect any template ending in a list. Guarding the separator only fixes the no-CSS case, though; the blank line is still appended after the template when CSS *is* set. So instead of guarding, the style block now goes **before** the template. `<style>` still starts its own CommonMark HTML block (type 1, blank-line-insensitive, runs to `</style>`), but the template itself is no longer modified, so its rendering is unchanged in both cases. Verified byte-identical to the current no-CSS baseline across HTML, list, heading, blockquote, GFM-table and fenced-code templates, with a regression test added for the tight-list case. Note for anyone reading the suggested diff: `formData.styleTemplate || ''` drops the `<style>` wrapper, which would stop the CSS applying entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
